Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Vector Transfer Support V3 #92

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

General Vector Transfer Support V3 #92

wants to merge 19 commits into from

Conversation

EdwardPalmer99
Copy link
Contributor

@EdwardPalmer99 EdwardPalmer99 commented Feb 1, 2024 •
edited
Loading

Changes

  • Brings PR General Vector Transfer Support V2 #75 up-to-date to master.
  • Renamed "ApolloApp" namespace to "Apollo" to prevent clashes.
  • Added support for MultiAppGeneralFieldShapeEvaluationTransfer transfers.
  • Added MultiAppGeneralFieldShapeEvaluationTransfer test cases.
  • Removes support for MultiAppCopyTransfer since this now supports vector transfers.

Notes

  • It should be possible to add additional MOOSE transfers in the future as required.
  • Rerun build test once Apollo updates MOOSE master version (should pass tests then!)

@EdwardPalmer99 EdwardPalmer99 changed the title General Vector Transfer V3 General Vector Transfer Support V3 Feb 1, 2024
@EdwardPalmer99 EdwardPalmer99 self-assigned this Feb 1, 2024
@EdwardPalmer99 EdwardPalmer99 marked this pull request as ready for review February 2, 2024 11:52
@EdwardPalmer99 EdwardPalmer99 marked this pull request as draft February 2, 2024 15:06
@EdwardPalmer99 EdwardPalmer99 marked this pull request as ready for review February 2, 2024 16:17
@alexanderianblair
Copy link
Contributor

Adding a comment here from our discussion - looks like the tests run fine currently, but fail when MOOSE is build with the Solid Mechanics module enabled. Unclear why, but may be linked to missing task dependencies for the new Action?

Given transfers of forces to MOOSE solid mechanics problems is one of the most likely use cases here, we probably want to fix this before merging - and possibly add solid mechanics as one of the modules built by default in the Apollo build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderianblair alexanderianblair Awaiting requested review from alexanderianblair

Requested changes must be addressed to merge this pull request.

Assignees

@EdwardPalmer99 EdwardPalmer99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwardPalmer99 @alexanderianblair